Skip to content

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Feb 11, 2023

Similar to #86451, but for the SEO descriptions instead of the search descriptions.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 11, 2023
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! r=me with the additional test link

@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2023
@camelid camelid assigned camelid and unassigned GuillaumeGomez Feb 11, 2023
@notriddle notriddle force-pushed the notriddle/intra-doc-link-meta-description branch from e09c520 to 72b3f46 Compare February 11, 2023 23:10
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r=camelid,GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented Feb 12, 2023

📌 Commit 72b3f46 has been approved by camelid,GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 12, 2023
…-meta-description, r=camelid,GuillaumeGomez

rustdoc: account for intra-doc links in `<meta name="description">`

Similar to rust-lang#86451, but for the SEO descriptions instead of the search descriptions.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 12, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107748 (refer to new home)
 - rust-lang#107842 (Patch `build/rustfmt/lib/*.so` for NixOS)
 - rust-lang#107930 (Improve JS function itemTypeFromName code a bit)
 - rust-lang#107934 (rustdoc: account for intra-doc links in `<meta name="description">`)
 - rust-lang#107943 (Document `PointerLike`)
 - rust-lang#107954 (avoid mixing accesses of ptrs derived from a mutable ref and parent ptrs)
 - rust-lang#107955 (fix UB in ancient test)
 - rust-lang#107964 (rustdoc: use tighter line height in h1 and h2)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9b50332 into rust-lang:master Feb 13, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 13, 2023
@notriddle notriddle deleted the notriddle/intra-doc-link-meta-description branch February 13, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants